feat(drive): add drive.copy tool for file/template copying#277
feat(drive): add drive.copy tool for file/template copying#277oskarcode wants to merge 3 commits intogemini-cli-extensions:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a focused capability to copy Google Drive files, significantly enhancing support for template-based document creation. By providing a dedicated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new drive.copy tool, which is a great addition for template-based workflows. The implementation is clean and follows the existing structure for adding new tools. I've identified one high-severity issue where the fileId is not being processed to handle Google Drive URLs, which is inconsistent with other Drive tools and the tool's own documentation. Applying the suggested fix will make the tool more robust and user-friendly.
| const drive = await this.getDriveClient(); | ||
|
|
||
| const requestBody: drive_v3.Schema$File = { name }; | ||
| if (folderId) { | ||
| requestBody.parents = [folderId]; | ||
| } | ||
|
|
||
| const copy = await drive.files.copy({ | ||
| fileId: fileId, | ||
| requestBody: requestBody, | ||
| fields: 'id, name, mimeType, webViewLink', | ||
| supportsAllDrives: true, | ||
| }); |
There was a problem hiding this comment.
For consistency with other tools like drive.trashFile and drive.renameFile, and to support the functionality described in the tool's input schema ('Can be extracted from a Google Drive URL'), the fileId should be processed with extractDocumentId. This will allow users to provide either a direct file ID or a full Google Drive URL.
| const drive = await this.getDriveClient(); | |
| const requestBody: drive_v3.Schema$File = { name }; | |
| if (folderId) { | |
| requestBody.parents = [folderId]; | |
| } | |
| const copy = await drive.files.copy({ | |
| fileId: fileId, | |
| requestBody: requestBody, | |
| fields: 'id, name, mimeType, webViewLink', | |
| supportsAllDrives: true, | |
| }); | |
| const drive = await this.getDriveClient(); | |
| const id = extractDocumentId(fileId); | |
| const requestBody: drive_v3.Schema$File = { name }; | |
| if (folderId) { | |
| requestBody.parents = [folderId]; | |
| } | |
| const copy = await drive.files.copy({ | |
| fileId: id, | |
| requestBody: requestBody, | |
| fields: 'id, name, mimeType, webViewLink', | |
| supportsAllDrives: true, | |
| }); |
1 participant
Summary
Adds a focused
drive.copytool to copy existing Google Drive files. This is useful for template-based workflows where users need to create a new document while preserving formatting/content from an existing file.New Tool
drive.copy- Copy a Drive file byfileId, set a newname, and optionally place it in a destinationfolderIdImplementation
copyFilemethod toDriveServicedrive.files.copyAPI with optional destination folder supportid,name,mimeType,webViewLinkhttps://www.googleapis.com/auth/drive), no new scopesFiles Changed
workspace-server/src/services/DriveService.ts- AddedcopyFilemethodworkspace-server/src/index.ts- Registereddrive.copyMCP tool with input schemaNotes